Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(database): move cursor in kanban card title by arrow keys #8893

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(database): move cursor in kanban card title by arrow keys #8893

merged 1 commit into from
Dec 11, 2024

Conversation

OlegDev1
Copy link
Contributor

@OlegDev1 OlegDev1 commented Dec 7, 2024

Fixes #8643

  • Fixes a bug where a user can not move the cursor with right and left arrow keys, when editing title of kanban cards
  • Added an e2e test case

Ran these test cases, they all pass:
tests/database/selection.spec.ts
tests/database/database.spec.ts

@OlegDev1 OlegDev1 requested a review from a team as a code owner December 7, 2024 16:06
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: 44e63cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 4:07pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 4:07pm

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 7, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2024

@OlegDev1 is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 44e63cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

doodlewind
doodlewind approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 10, 2024 •
edited
Loading

Merge activity

  • Dec 10, 1:42 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 1:43 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@OlegDev1
Copy link
Contributor Author

@doodlewind you are welcome! Love the quality of the codebase

@Saul-Mirone Saul-Mirone merged commit 4366c6b into toeverything:master Dec 11, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

​Kanview view cannot use left and right key to move cusor when editing title of cards
3 participants
@OlegDev1 @doodlewind @Saul-Mirone